Reviewing code can feel like a secondary task. Discussing code can be easy though, if you leave out syntax details. Following a couple of guide lines for pull requests can make code reviewing much easier.

Some code style rules can drastically reduce the mental overhead needed to understand code changes. Furthermore this talk will give some general guidelines on how to give feedback on PRs as a peer developer or coworker. These rules are not to keep for yourself, share them with your peers and your life will get easier.


Comments are closed.

Brad Bird at 12:06 on 17 Feb 2017

Great talk! Definitely looking forward to discount some

Brad Bird at 12:07 on 17 Feb 2017

Apparently emojis don't work on joindin but that was meant to say "looking forward to dishing out some s*@t burgers on monday"

Riya dennis at 12:09 on 17 Feb 2017

Very good talk, will surely help while submitting and reviewing pull requests.

This is a strong, well delivered talk. Pleased that we already do a lot of these things, but still some things to work on! The only thing that might improve this would be some examples of real life PRs and reviews that do or don't do these things.

Fun, actionable talk!

David Yell at 14:46 on 17 Feb 2017

Good talk

Davo Smith at 20:21 on 17 Feb 2017

Not a bad talk, but didn't offer any unexpected insights into the peer review process (or maybe I've just done enough of them over the years that it mostly just seemed obvious).

Enjoyable and confidently presented talk. I just wish I worked in a big enough team for proper code reviews to be a real possibility!