We all make mistakes, as much as we try to write flawless code, every now and then an error slips through. In order to reduce this number we do code reviews to ensure the code meets certain standards and to see if the feature was properly implemented. But how do you do a good code review? How do you handle technical discussions? How do you keep your reviews focused and your discussions relevant? In this talk I would like to show you how you can do proper code reviews, what to look out for when doing them, how to give feedback to the developer and a bunch of other tips to improve this process.

Comments

Comments are closed.

Very interesting and nice to hear that we as a company are doing it right

Rated 3

Rico Humme at 15:48 on 8 Jun 2018

Nice to hear other concepts but i was hoping on hearing about tools to make life easier and how to use this in a correct way.

RIck is such a natural speaker, I love his style of speaking. The talk itself was also very good (and I'm not just saying that because of the WeCamp references ;) ) with a good overview of pitfalls and tips and tricks, and of course the ways of selling code reviewing to management. Both entertaining and educating. Well done!

Very insightful talk into why code reviews are good and how best to use them.

Rated 5

Dennis C. at 11:23 on 9 Jun 2018

Rick is a great speaker with a good sense of humor and he really believes what he preaches, but it's not to repetitive.

You might also be interested in post commit review options such as reviewboard,
We do a weekly review roulette, you can check out my co-workers blog for more info:
https://www.moxio.com/blog/8/introducing-review-roulette
https://www.moxio.com/blog/15/review-roulette-everyone-is-a-winner

Really well delivered insightfull talk. Good combination of theory and practical experience. Rick has a great sense of humour, that made the talk really entertaining.

We went in saying to each other: we should probably just do it. We went out with a bit more of a hands on feel about it, but it is still - just do it, really .

Rated 4

Srdjan Vranac at 17:24 on 10 Jun 2018

Excellent talk on an interesting subject that was nicely delivered.
One thing that might be missing is just a bit more focus on tools available to reduce the pain of diffs.

I think this is an interesting topic that was well given.
Rick talks very smooth and has a nice stage presence.

Content wise I would love it if we went a bit deeper on the tools to perform better code reviews.
Maybe show some screenshots for the PHPStorm way of doing it.

Well done!

I really enjoyed this talk, thank you very much!

I really liked your talk. So much that we already made some changes to our code review process today (first monday after the conference).
Thank you!

Rated 5

Onno Marsman at 13:29 on 11 Jun 2018

Best talk I went to in the conference. Very interesting and great responses to the audience.

Good talk, but a lot of it was spent explaining why code reviews are a good thing. Not very useful if you're already on board with that. Good speaker though.