A Meritocracy of Pull Requests

Lorna Mitchell

Saturday 13 April 2019 from 09:30 to 10:20

Talk in English - UK at PHP Yorkshire 2019
Track Name: Track 1
View Slides: https://noti.st/lornajane/cRVl2F/a-meritocracy-of-pull-requests
Short URL: https://joind.in/talk/b45a3 (QR-Code (opens in new window))

Avg. Rating

We often speak of open source as a meritocracy; everyone's patches are welcome. However with git used in the workplace as well as open source, being good at pull requests is a key career skill for all developers. This talk combines git tips, psychology and years of experience to present key information on working with pull requests. How to open one in a way that will make it more likely to be accepted without drama. How to review and evaluate a pull request so you don't regret it in the morning. How (and if) to merge pull requests, including those big words like rebasing and squashing. And how to close them, merged or not. This talk recommended for everyone who uses pull requests and wants to work on this key skill.

Comments

Comments are closed.

Richard Harrison at 10:36 on 13 Apr 2019 (via Web2 LIVE)

I enjoyed this talk. It was well paced and clearly delivered. Could only give 4 stars though as it was more of a refresher than an introduction to new stuff.

Asmir Mustafic at 11:36 on 13 Apr 2019 (via Web2 LIVE)

A good talk and very well presented.
Was hoping into something more to be honest, both on tech side or on the soft skills side...

Michael Adamson at 12:43 on 13 Apr 2019 (via Web2 LIVE)

Delivered with energy and expertise, lots of both technical and non-technical words of wisdom.

Adam Duffield at 14:49 on 13 Apr 2019 (via Web2 LIVE)

I came in expecting to get the least from this talk and regarded it as the best so far. Good energy, room to learn for everyone, good collaboration is a win for everyone.

Daniel Craigie at 14:50 on 13 Apr 2019 (via Web2 LIVE)

Good talk, gave me lots to think about for projects at work and home. Good sprinkling of comic elements as well.

Benjamin Wells Kerenza at 15:59 on 13 Apr 2019 (via Web2 LIVE)

A useful reminder

Scott Dutton at 08:30 on 14 Apr 2019 (via Web2 LIVE)

Great talk from Lorna as always.

Chris Emerson at 16:41 on 14 Apr 2019 (via Web2 LIVE)

This was a really interesting talk about the best ways to manage pull requests and the discussions and reviews around them. There were some really interesting ideas in here and suggestions about how to review code, deal with a PR that is never going to pass and getting the best out of people and code when accepting PRs too. Will certainly be putting a lot of this into practice where I can!

Gavin Taylor at 19:25 on 14 Apr 2019 (via Web2 LIVE)

this talk is full of great tips for both folk new to the process and those of us that have been doing it a while.

might be a few process changes on Monday :)

Anthony Chambers at 12:59 on 15 Apr 2019 (via Web2 LIVE)

During the entire talk I was considering how we manage PRs at work, and while I don't necessarily agree on all of Lorna's points, it's great to challenge your beliefs and conventions. The delivery was fantastic. I wouldn't change a thing

Aaron Henderson at 12:49 on 17 Apr 2019 (via Web2 LIVE)

Lorna's delivery was great, informative, delivered with confidence and enthusiasm. This was a good way to start the day and left me striving to work better inside version control.