PHPSW: Code Review & PWAs, April 2018 [Bath Edition]
25 Apr 2018 at Bath Innovation Centre

Very informative and well researched, thanks for a great talk

Great talk really enjoyed.

A great talk on code review with lots of things to take away from it. It would be good if there was a bit more time on the technical integration of it into workflow. I liked the examples and references throughout.

Refreshing intro!
Loved use of props!!! Needs more visibility - maybe a thick, bright ribbon, higher up if possible?
V good analogy. I love life-or-death analogies for code because sometimes it really is.
It would be good to give examples of why bugs cost us and increase in cost, briefly. The arrow on the graph was really powerful.
Text on your personal info slide was too close to the edge, and a bit lightweight for the amount of text on the slide (did that make sense?).

I'd prefer more paraphrasing of the slides or examples of the bullet points in the slides.
I love that you went into the benefits of code review outside of bug catching.
I'm going to use those evolvability stats in a spike next week - useful!! My big fear when receiving very shallow reviews are evolvability bugs slipping under the radar.

I think it would be powerful to gesture to the green line at the beginning, when it's higher than the blue line, to acknowledge the upfront cost.

I live and breathe for the security review side!!

I love the 'How many tests do we need', they make me feel clever and they make a very good point.
I love that you talked about bad (or sometimes just unreadable/wizard magic) code, that's so important to me.

Cost of writing code slide was cool and well presented, I like fat graphics.
Reviewing naming! Yaaaasss! Slash documentation?

Are your code review standards/guidelines public? If so, please share it!

Talking about leveraging your IDE is really good, but a lot of it sounds like benefits after the fact of code review rather than IN code review?

Please mention the benefit of a no blame culture - which comes from the shared responsibility of the codebase. It is especially valuable because people are more likely to own/admit less than perfect things.

Do you review commit messages?
Those Cisco tips were REALLY valuable. Will bear that in mind.

I would add the receiving review tip of actioning feedback to the same standard as the rest of your code - I find a lot of people rush it or hack it because they want to their PR thru asap, but it just slows the follow up review.

Would potentially recommend putting a cross and a tick into the good/bad commit head circles for people who are red/green colour blind.

Really appreciated the summary slide, it was very good.

The conversation on reviewing juniors was really helpful and validating for me, thank you for answering my questions.


General delivery was really good, would have enjoyed a bit more humour to break it up, but overall it was informative, smart, comprehensive and useful. Thank you!!

Liked the scuba diving reference to kick things off! Lots of good examples of code that needs to be reviewed, and packed with useful tips!

The text on the slides could do with a little more contrast perhaps as it’s wasnt so easy to read from the back of the room, likely to be even harder in a larger venue :)